Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix distributable_post_types filter #158

Merged
merged 2 commits into from
Jul 25, 2018
Merged

Prefix distributable_post_types filter #158

merged 2 commits into from
Jul 25, 2018

Conversation

barryceelen
Copy link
Member

The distributable_post_types should prefixed to dt_distributable_post_types. This could be a breaking change for some users.

barryceelen added a commit that referenced this pull request Jul 7, 2018
@barryceelen
Undo prefix 'distributable_post_types' filter
d5ba46d 
This somehow snuck in and is a potential breaking
change handled in #158
@barryceelen
Copy link
Member Author

Lumped in the unprefixed oauth_admin_notices action as well.

Not sure if we'd want to retain the renamed action and filter and use apply_filters_deprecated() and do_action_deprecated() to mark them such.

@barryceelen barryceelen mentioned this pull request Jul 14, 2018
Merged
@tlovett1 tlovett1 merged commit 5803c1a into master Jul 25, 2018
@barryceelen barryceelen deleted the fix/prefix-distributable-post-types-filter branch July 30, 2018 14:25
@barryceelen
Copy link
Member Author

barryceelen commented Jul 31, 2018 •
edited
Loading

@tlovett1 Renaming the filter to dt_distributable_post_types did not make it into master (I'm assuming due to my changing and reverting in another pull request).

@barryceelen barryceelen restored the fix/prefix-distributable-post-types-filter branch July 31, 2018 10:06
@barryceelen barryceelen deleted the fix/prefix-distributable-post-types-filter branch July 31, 2018 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barryceelen @tlovett1