Fix issues reported for v1.8.1 release #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkotter
approved these changes
Sep 10, 2024
| @@ -40,7 +40,11 @@ | |||
| $episode_type = get_post_meta( $post_id, 'podcast_episode_type', true ); | |||
| $episode_number = get_post_meta( $post_id, 'podcast_episode_number', true ); | |||
| $season_number = get_post_meta( $post_id, 'podcast_season_number', true ); | |||
| $term_image_id = get_term_meta( $podcast_show->term_id, 'podcasting_image', true ); | |||
| if ( is_a( $podcast_show, 'WP_Term' ) ) { | |||
There was a problem hiding this comment.
Note that this solves the undefined issue but doesn't actually solve the root problem, where the proper data isn't actually set on any existing blocks, even if the data was there before. I'm fine with adding this defensive check but just want to ensure we don't lose the thread on the larger issue
dkotter
requested changes
Sep 10, 2024
…any PHPCS failures are flagged
dkotter
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR fixes some of the issues reported in #313
The following are the two issues that are fixed in this PR.
Partially Closes #313
How to test the Change
Here are the steps to test the first change
Here are the steps to test the second change
Changelog Entry
Credits
Props @sudar
Checklist: