Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to dock player to top or bottom of page #331

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

wadebekker
Copy link

Description of the Change

This PR adds the ability to dock the player to the top or bottom of the page, in addition to the original 'inline' option.
When docked, the podcast details are hidden initially to save height. A 'More/Less' button is available to hide or reveal the podcast details.

Please note: This feature is still a WIP
Further styling is still required on the 'More/Less' button and layout, and general spacing needs to be reviewed and tested.
This feature is not yet fully tested in all major browsers and viewport sizes.

Closes #299

How to test the Change

  • Checkout PR branch
  • Run the project using Local
  • Open the website and log into the WP Admin Dashboard

From within the WP Admin Dashboard:

  • Create a Podcast.
  • Add a Podcast Block to a new or existing post.
  • Insert your podcast episode into the Podcast Block.
  • Inside the block editor panel, under 'Podcast Settings', a new set of controls labeled 'Dock Player' is available.
  • Toggle between 'Top', 'Bottom', 'None' to test the various docking options.
  • Toggle on a few of the 'Podcast Settings' options to test the 'More/Less' functionality.
  • Save/Publish your post to test the frontend output (outside of the WP admin area).

Changelog Entry

Added - New feature

Credits

@wadebekker

Checklist:

Desired results:

The designs below illustrate our goals for both mobile and desktop views. Note: When docked at the top, the player should remain visually identical but fixed to the top of the page.

desktop
mobile

@wadebekker wadebekker requested a review from a team as a code owner January 3, 2025 08:56
@wadebekker wadebekker requested review from peterwilsoncc and removed request for a team January 3, 2025 08:56
@github-actions github-actions bot added this to the Future Release milestone Jan 3, 2025
@github-actions github-actions bot added the needs:code-review This requires code review. label Jan 3, 2025
@jeffpaul jeffpaul modified the milestones: Future Release, 2.0.0 Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Player enhancements - Ability to have the player docked to header or footer location on site.
2 participants