This repository has been archived by the owner on Apr 21, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Adding a page for Tiny Slider based on a review to confirm compliance with WCAG 2.1AA
Alternate Designs
I'm not sure that this applies, but the slider was tested in multiple scenarios, manually, in addition to analyzing http://ganlanyuan.github.io/tiny-slider/demo/ (this page is not very accessible), to ensure that there are ways to use the slider accessibly.
Benefits
We will now have an approved slider
Possible Drawbacks
It is still possible to use the slider in an inaccessible way.
This may not be the best solution for use with react since it manipulates the DOM directly.
Verification Process
In order to verify that the slider is accessible, I built a few fake pages that had different instances of the slider in different use cases.
I build one that had just a few slides that were just images, another that had images and text, and another that had links. I tested all of these with controls, and on both autoplay and non-autoplay.
In order to check compliance, I used a combination of Lighthouse accessibility audit, Axe accessibility audit, and manually checking against the WCAG2.1 guidelines https://www.w3.org/TR/WCAG21/ using windows narrator, Mac OS Voiceover, and NVDA screen reader, and manually navigating the pages with only the keyboard.
Checklist:
Applicable Issues