Fixed header, nav and footer nav #3986
Conversation
content/pages/about.md
Outdated
| @@ -1,6 +1,9 @@ | |||
| --- | |||
| title: About 18F | |||
| permalink: /about/ | |||
| eleventyNavigation: | |||
There was a problem hiding this comment.
clarification: It's starting to look like we have two different methods for setting navigation info — the navigation data, and now this. Is that perception correct?
There was a problem hiding this comment.
Stopped using the 11ty nav plugin. Should we uninstall the plugin?
Created a nav collection from a cleaned up _data/navigation.yml and built the nav from that.
There was a problem hiding this comment.
Uninstalling the plugin feels out of scope for this issue, but feel free to add it to #3864
_includes/menu.html
Outdated
| <a href="https://search.usa.gov/search?utf8=%E2%9C%93&affiliate=18F-site&query=&commit=" | ||
| class="usa-button padding-x-2" | ||
| > | ||
| <img src="/assets/uswds/img/usa-icons-bg/search--white.svg" |
There was a problem hiding this comment.
The link checker failed to find the asset as written.
Use the image shortcode for this asset, I think it would be:
{% image "assets/uswds/img/usa-icons-bg/search--white.svg" "Search" %}
(No leading slash)
Also for future reference, npm run precommit will run all the build checks locally.
There was a problem hiding this comment.
Fixed. Thanks for the tip!
|
Thank you for the review! I will make the suggested updates. |
jasnakai
changed the title
content/pages/about.md
Outdated
| @@ -1,6 +1,9 @@ | |||
| --- | |||
| title: About 18F | |||
| permalink: /about/ | |||
| eleventyNavigation: | |||
There was a problem hiding this comment.
Uninstalling the plugin feels out of scope for this issue, but feel free to add it to #3864
|
@beechnut Hey, Matt. The page build check is having an issue but I do not think it is from my updates. I made one edit to try and fix the build issue but that didn't do the trick. It builds fine locally. Any ideas on how to fix the build check? TIA! |
|
@jasnakai I suspect the merge conflicts are coming from the back-and-forth of making and then reverting changes. Can you squash these into 1 commit and force push? I think that will clear it. |
|
@beechnut Whatever issues were present are now resolved and the this is ready to merge. Is it ok for me to squash and merge instead? Thanks! |
…ges to 11ty nav. Added nav to header and footer. Fixed header styling to match live 18f site. Addressed draft PR comments.
Pull request summary
Closes #3853.