Update to Ruby 3.2.0 #7594
Merged
Update to Ruby 3.2.0 #7594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙃 |
mitchellhenke
force-pushed
the
mitchellhenke/ruby-3.1
branch
8 times, most recently
from
109b2ba to
0cc0fd3
Compare
Happy to explore it in a future PR if 3.2 works 😀 For explicitness, the substitution is to make use of some syntax changes for hashes and keyword arguments released in Ruby 3.1:
|
Yep, totally fair. After I posted the comment, I also realized there's likely a Rubocop cop which can enforce / fix this for us, probably more reliable than command-line substitution. |
zachmargolis
approved these changes
Jan 11, 2023
Gemfile
Outdated
| gem 'capybara-webmock', git: 'https://github.com/hashrocket/capybara-webmock.git', ref: '63d790a0' | ||
| gem 'data_uri', require: false | ||
| gem 'capybara-webmock', git: 'https://github.com/mitchellhenke/capybara-webmock.git', | ||
| ref: 'c23b02f' |
There was a problem hiding this comment.
for posterity, changes captured in this PR
There was a problem hiding this comment.
the PR has been merged, so I switched back to their repo in our Gemfile
mitchellhenke
force-pushed
the
mitchellhenke/ruby-3.1
branch
2 times, most recently
from
45fa4fa to
3d0d1c6
Compare
Closed
mitchellhenke
force-pushed
the
mitchellhenke/ruby-3.1
branch
from
3d0d1c6 to
c82dac5
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Update to Ruby 3.2.0!
Nokogiri is the remaining piece that's still a release candidate, but I think we could consider moving forward with it if we're comfortable.