Add tests to service_provider validate method #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am going to include these tests in an upcoming change. |
|
The intended PR would have introduced breaking changes as the way we are currently handling validations is not optimal. Therefore, I am going to put that work on pause, but still want these tests to be integrated into the code base. |
Jeremy1026
approved these changes
Nov 29, 2023
zachmargolis
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got worried I'd found a bug in the validation code, but it was hard to reason about, so I wrote a bunch of tests. It looks like there is not a bug, and now we have some tests for the service_provider.rb file.