Skip to content

Commit

Permalink
Merge pull request #98 from 18F/sw-uswds-update-fix
Browse files Browse the repository at this point in the history
Hotfix for USWDS v1.4.4 update
  • Loading branch information
Scott Weber authored Jan 12, 2018
2 parents 45659ba + 0e7f13b commit 3c2799b
Show file tree
Hide file tree
Showing 35 changed files with 48 additions and 49 deletions.
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
uswds-jekyll (2.2.0)
uswds-jekyll (2.2.1)
jekyll (~> 3.4)

GEM
Expand Down
2 changes: 1 addition & 1 deletion _sass/uswds/components/_header.scss
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ $z-index-nav: 9000;
@include position(fixed, 0);
background: $color-black;
opacity: 0;
transition: all 0.2s ease-in-out;
transition: opacity 0.2s ease-in-out;
visibility: hidden;
z-index: $z-index-overlay;

Expand Down
23 changes: 23 additions & 0 deletions _sass/uswds/components/_sidenav.scss
Original file line number Diff line number Diff line change
@@ -1,8 +1,31 @@

.usa-sidenav-list {
@include usa-sidenav-list;
border-bottom: 1px solid;
border-top: 1px solid;

@include media($large-screen) {
border-bottom: none;
border-top: none;
}

.usa-grid & {
@include margin(null (-$site-margins-mobile) null (-$site-margins-mobile));

@include media($medium-screen) {
@include margin(null 0);
}
}
}

.usa-sidenav-sub_list {
@include usa-sidenav-sublist;
}

.usa-layout-docs-sidenav {
padding-top: 2.4rem;

@include media($large-screen) {
padding-top: 0;
}
}
6 changes: 3 additions & 3 deletions _sass/uswds/core/_utilities.scss
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@
display: block;
font-family: $font-sans;
line-height: 1.3;
padding: 0.85rem 1rem 0.85rem 1.8rem;
padding: 0.85rem 1rem 0.85rem $site-margins-mobile;
text-decoration: none;

&:hover {
Expand All @@ -207,10 +207,10 @@
}

&.usa-current { /* stylelint-disable-line selector-no-qualifying-type */
border-left: 0.4rem solid $color-primary;
border-left: $sidenav-current-border-width solid $color-primary;
color: $color-primary;
font-weight: $font-bold;
padding-left: 1.4rem;
padding-left: $site-margins-mobile - $sidenav-current-border-width;
}
}
}
Expand Down
31 changes: 16 additions & 15 deletions _sass/uswds/core/_variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -128,21 +128,22 @@ $image-path: '../img' !default;
$asset-pipeline: false !default;

// Magic Numbers
$text-max-width: 66ch !default; // 66 characters per line
$lead-max-width: 77rem !default;
$site-max-width: 1040px !default;
$site-margins: 3rem !default;
$site-margins-mobile: 1.5rem !default;
$article-max-width: 600px !default;
$input-max-width: 46rem !default;
$label-border-radius: 2px !default;
$checkbox-border-radius: 2px !default;
$border-radius: 3px !default;
$button-border-radius: 5px !default;
$box-shadow: 0 0 2px $color-shadow !default;
$focus-outline: 2px dotted $color-gray-light;
$focus-spacing: 3px;
$nav-width: 951px !default;
$text-max-width: 66ch !default; // 66 characters per line
$lead-max-width: 77rem !default;
$site-max-width: 1040px !default;
$site-margins: 3rem !default;
$site-margins-mobile: 1.5rem !default;
$article-max-width: 600px !default;
$input-max-width: 46rem !default;
$label-border-radius: 2px !default;
$checkbox-border-radius: 2px !default;
$border-radius: 3px !default;
$button-border-radius: 5px !default;
$box-shadow: 0 0 2px $color-shadow !default;
$focus-outline: 2px dotted $color-gray-light !default;
$focus-spacing: 3px !default;
$nav-width: 951px !default;
$sidenav-current-border-width: 0.4rem !default; // must be in rem for math

// 44 x 44 pixels hit target following Apple iOS Human Interface
// Guidelines
Expand Down
4 changes: 3 additions & 1 deletion _sass/uswds/elements/_inputs.scss
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,9 @@ select {
appearance: none;
background-color: $color-white;
background-image: url('#{$image-path}/arrow-both.png');
background-image: url('#{$image-path}/arrow-both.svg');
// Ensure browsers that don't support SVG in background-image (IE 11 and below) fall back to PNG.
// See https://www.broken-links.com/2010/06/14/using-svg-in-backgrounds-with-png-fallback/
background-image: none, url('#{$image-path}/arrow-both.svg'), url('#{$image-path}/arrow-both.png');
background-position: right 1.3rem center;
background-repeat: no-repeat;
background-size: 1rem;
Expand Down
Binary file modified assets/uswds/img/angle-arrow-down-hover.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/uswds/img/angle-arrow-down-primary-hover.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/uswds/img/angle-arrow-down-primary.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/uswds/img/angle-arrow-down.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/uswds/img/angle-arrow-up-primary-hover.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/uswds/img/angle-arrow-up-primary.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/uswds/img/arrow-both.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/uswds/img/circle-124.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/uswds/img/close-primary.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/uswds/img/close.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/uswds/img/external-link-alt-hover.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/uswds/img/external-link-alt.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/uswds/img/external-link-hover.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/uswds/img/external-link.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/uswds/img/favicons/favicon-114.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/uswds/img/favicons/favicon-40.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/uswds/img/favicons/favicon-57.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/uswds/img/hero.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/uswds/img/minus-alt.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/uswds/img/plus-alt.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/uswds/img/search-alt.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/uswds/img/search-primary.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/uswds/img/social-icons/png/facebook25.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/uswds/img/social-icons/png/rss25.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/uswds/img/social-icons/png/twitter16.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/uswds/img/social-icons/png/youtube15.png
19 changes: 0 additions & 19 deletions assets/uswds/scss/lib/_bourbon-deprecate.scss

This file was deleted.

8 changes: 0 additions & 8 deletions assets/uswds/scss/lib/settings/_deprecation-warnings.scss

This file was deleted.

2 changes: 1 addition & 1 deletion uswds-jekyll.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Gem::Specification.new do |s|
s.name = 'uswds-jekyll'
s.version = '2.2.0'
s.version = '2.2.1'
s.authors = ['Shawn Allen', 'Brian Hurst', 'Scott Weber']
s.email = ['[email protected]', '[email protected]']

Expand Down

0 comments on commit 3c2799b

Please sign in to comment.