Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion to also allow BLE WRITE procedures for WriteWithoutResponse characteristics #1037

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Suggestion to also allow BLE WRITE procedures for WriteWithoutResponse characteristics #1037

merged 1 commit into from
Jul 27, 2021

Conversation

DigiH
Copy link
Collaborator

@DigiH DigiH commented Jul 26, 2021

While playing with the new BLE READ/WRITE feature for my Playbulb Candles I found that writing was not possible for characteristics which are WriteWithoutResponse only.

I implemented this quick fix which might be useful for others with devices for which they want to write to WriteWithoutResponse characteristics.

Alternatively a more slective option could be possible for a future release, i.e. adding an additional WRITE tag like "ble_write_withoutresponse": true/false

Description:

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

…ch are only WriteWithoutResponse

While playing with the new BLE READ/WRITE feature for my Playbulb Candles I found that writing was not possible for characteristics which are WriteWithoutResponse only.

I implemented this quick fix which might be useful for others with devices for which they want to write to WriteWithoutResponse characteristics.

Alternatively a more slective option could be possible for a future release, i.e. adding an additional WRITE tag like "ble_write_withoutresponse": true/false
@1technophile 1technophile requested a review from h2zero July 26, 2021 21:32
Copy link
Collaborator

@h2zero h2zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@1technophile 1technophile added this to the v0.9.8 milestone Jul 27, 2021
@1technophile 1technophile merged commit 2d82cac into 1technophile:development Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants