Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LORA] Allow LORA CUSTOM PINS #1712

Merged
merged 4 commits into from
Jul 11, 2023
Merged

[LORA] Allow LORA CUSTOM PINS #1712

merged 4 commits into from
Jul 11, 2023

Conversation

nikito7
Copy link
Contributor

@nikito7 nikito7 commented Jul 11, 2023

Description:

Fix change pins via *_env.ini

Example code:

  '-DGateway_Name="OMG_ESP32_LORA"'
  '-DZgatewayLORA="LORA"'
  '-DLORA_BAND=868E6'
  '-DLORA_CUSTOM_PINS'
  '-DLORA_SCK=14'
  '-DLORA_MISO=12'
  '-DLORA_MOSI=13'
  '-DLORA_SS=15'
  '-DLORA_RST=16'
  '-DLORA_DI0=5'

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

@nikito7 nikito7 marked this pull request as ready for review July 11, 2023 14:40
@1technophile
Copy link
Owner

Thanks, to be consistent with the other gateways and sensors config could you add the ifndef per pin instead
Example :

 # IFNDEF LORA_SCK
 # DEFINE LORA_SCK 14
 # ENDIF

@nikito7
Copy link
Contributor Author

nikito7 commented Jul 11, 2023

I could try.

From my tests. *_env do not override config_LORA defaults

@1technophile
Copy link
Owner

Indeed, you need to modify the config_LORA.h with an ifndef for each pins if you want to use them in a *_env.ini, this can be proposed in this PR

@nikito7 nikito7 changed the title Add LORA_CUSTOM_PINS Allow LORA CUSTOM PINS Jul 11, 2023
@1technophile
Copy link
Owner

Thanks

@1technophile 1technophile merged commit 0d8275b into 1technophile:development Jul 11, 2023
71 checks passed
@1technophile 1technophile changed the title Allow LORA CUSTOM PINS [LORA] Allow LORA CUSTOM PINS Jul 11, 2023
@nikito7 nikito7 deleted the lora-custom-pins branch July 11, 2023 21:33
@ViPeR5000
Copy link

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants