[RF] rain_rate_mm_h fix #1713
Merged
[RF] rain_rate_mm_h fix #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thks, original was taken from https://github.com/merbanan/rtl_433/blob/1026deab33372e4fe2e6c1d4c0f3df0c02c491be/examples/rtl_433_mqtt_hass.py#L362 Not sure if we should remove rain_mm_h or keep it added to rain_rate_mm_h |
|
Initially I thought that as well, but in all the rtl_433_ESP decoders I couldn't find any rain_mm_h at all, only ever rain_rate_mm_h, so not sure where rain_mm_h could come from otherwise. Same for rtl_433 actually, only ever mentioned in the example, probably an old/legacy/wrong entry. |
|
Make sense, maybe we should submit a PR in rtl_433 repo |
|
See my link above :) |
1technophile
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://community.openmqttgateway.com/t/rain-rate-mm-h-ignored/2597
as defined in several rtl_433 decoders
Checklist: