Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console log formatting #1759

Closed

Conversation

lulol
Copy link
Contributor

@lulol lulol commented Sep 23, 2023

Description:

Fix some console log formatting that is actually mixed with LF and CRLF.

To work properly still is need to change in ArduinoLog/ArduinoLog.h
#define CR "\n" <<< actually LF
to
#define CR "\r\n"
or to use NL instead of CR in all the relevant files.
NL is available in the latest version of ArduinoLog.

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

Fix some console log formatting that is actually mixed with CR and CRLF.

To work properly still is need to change in ArduinoLog/ArduinoLog.h
`#define CR "\r\n"`
or to use NL instead of CR in all the relevant files available in the latest version of ArduinoLog.
@1technophile
Copy link
Owner

Thanks for pointing this, I have fixed it in the Arduino log fork

@1technophile 1technophile mentioned this pull request Jan 11, 2024
3 tasks
@lulol lulol deleted the lulol-console_formatting-1 branch May 16, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants