-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Dockerfile #317
base: main
Are you sure you want to change the base?
Improve Dockerfile #317
Conversation
Use VIRTUAL_ENV into Dockerfile instead of user system path Improve local image size optimization
Remove `k8s` and add `terraform` directory from dockerignore
I would do without depending on customizing the $PATH in the IDE, as this PR is currently hinting at. Else, we would make the development environment unreasonably stiffer for all non Talos-based projects. |
8f84895
to
29d0782
Compare
The IDE |
As I mentioned already, I'd rather not do that, because unfortunately 20tab does not entail Talos-based projects only. |
I understand your concern about the broader impact on non-Talos projects. However, this PR is specifically focused on Talos, so the adjustments discussed would apply only within this project's scope. This should prevent any unintended constraints on unrelated 20tab projects. |
What's with the ChatGPT-style of reply? 😄 Anyways, anything ending up in Talos should make the team's life easier. That's the angle we should keep in mind. |
k8s
and addterraform
directory from .dockerignore