Skip to content

Commit

Permalink
Remove version number from package.json and set it via github action
Browse files Browse the repository at this point in the history
  • Loading branch information
apfelbox committed Mar 13, 2024
1 parent ec1f747 commit 8ac9e0c
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 8 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ jobs:
version: 'latest'
run_install: true

- name: Set version number in package.json
run: pnpm version from-git --no-git-tag-version

- name: Run Build
run: pnpm run prepare-release

Expand Down
11 changes: 5 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,9 @@ Development
### Releases

1. Check the CHANGELOG, to ensure that the next version number is correct according to semver and there is no "(unreleased)" after the next version number.
2. Bump the version number in `package.json`.
3. Commit these changes, commit message "Release x.y.z"
4. Push these changes
5. Tag the latest commit with "x.y.z"
6. Push the tag.
2. Commit these changes, commit message "Release x.y.z"
3. Push these changes
4. Tag the latest commit with "x.y.z"
5. Push the tag.

Publishing to npm is done automatically in a Github action.
Publishing to npm is done automatically in a GitHub action.
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"name": "@21torr/dune",
"version": "2.0.2",
"description": "A library of commonly used JS functionality.",
"license": "MIT",
"homepage": "https://github.com/21TORR/dune",
Expand All @@ -15,7 +14,7 @@
"dev": "tsc --project tsconfig.build.json --noEmitOnError --noErrorTruncation --listEmittedFiles --pretty -w",
"lint": "prettier-package-json --use-tabs --list-different",
"prepare-release": "pnpm run build && cd dist && npm pack --dry-run && publint",
"test": "pnpm build && cd dist && npm pack --dry-run && publint"
"test": "pnpm run build && cd dist && pnpm version '2.0.0-dummy' --no-git-tag-version && npm pack --dry-run && publint"
},
"dependencies": {
"xtend": "^4.0.2"
Expand Down

0 comments on commit 8ac9e0c

Please sign in to comment.