Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump required version, fix bin path #5

Merged
merged 6 commits into from
May 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
1.0.1
=====

* (bug) Fix invalid path to phpstan executable.
* (bug) Remove obsolete PHP-CS-Fixer installation in `phpstan` bin.
* (improvement) Bump required versions.
* (bug) Disable not-yet-released PHPStan rule for now.
* (feature) Add `staabm/phpstan-todo-by` extension.


1.0.0
=====

Expand Down
2 changes: 1 addition & 1 deletion _init/library/vendor-bin/cs-fixer/composer.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"require-dev": {
"21torr/php-cs-fixer": "^1.0",
"21torr/php-cs-fixer": "^1.0.2",
"roave/security-advisories": "dev-latest"
}
}
14 changes: 7 additions & 7 deletions _init/library/vendor-bin/phpstan/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
"php": "^8.3"
},
"require-dev": {
"friendsofphp/php-cs-fixer": "^3.2.1",
"phpstan/extension-installer": "^1.1.0",
"phpstan/phpstan": "^1.1.2",
"phpstan/phpstan-deprecation-rules": "^1.0.0",
"phpstan/phpstan-doctrine": "^1.0.1",
"phpstan/phpstan-symfony": "^1.0.1",
"roave/security-advisories": "dev-latest"
"phpstan/extension-installer": "^1.3.1",
"phpstan/phpstan": "^1.10.67",
"phpstan/phpstan-deprecation-rules": "^1.1.4",
"phpstan/phpstan-doctrine": "^1.3.69",
"phpstan/phpstan-symfony": "^1.3.12",
"roave/security-advisories": "dev-latest",
"staabm/phpstan-todo-by": "^0.1.25"
},
"config": {
"sort-packages": true,
Expand Down
2 changes: 1 addition & 1 deletion _init/symfony/vendor-bin/cs-fixer/composer.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"require-dev": {
"21torr/php-cs-fixer": "^1.0",
"21torr/php-cs-fixer": "^1.0.2",
"roave/security-advisories": "dev-latest"
}
}
14 changes: 7 additions & 7 deletions _init/symfony/vendor-bin/phpstan/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
"php": "^8.3"
},
"require-dev": {
"friendsofphp/php-cs-fixer": "^3.2.1",
"phpstan/extension-installer": "^1.1.0",
"phpstan/phpstan": "^1.1.2",
"phpstan/phpstan-deprecation-rules": "^1.0.0",
"phpstan/phpstan-doctrine": "^1.0.1",
"phpstan/phpstan-symfony": "^1.0.1",
"roave/security-advisories": "dev-latest"
"phpstan/extension-installer": "^1.3.1",
"phpstan/phpstan": "^1.10.67",
"phpstan/phpstan-deprecation-rules": "^1.1.4",
"phpstan/phpstan-doctrine": "^1.3.69",
"phpstan/phpstan-symfony": "^1.3.12",
"roave/security-advisories": "dev-latest",
"staabm/phpstan-todo-by": "^0.1.25"
},
"config": {
"sort-packages": true,
Expand Down
4 changes: 2 additions & 2 deletions bin/janus
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ function initializeSymfony (SymfonyStyle $io) : int
"vendor-bin/cs-fixer/vendor/bin/php-cs-fixer fix --diff --config vendor-bin/cs-fixer/vendor/21torr/php-cs-fixer/.php-cs-fixer.dist.php --dry-run --no-interaction --ansi",
],
"test" => [
"vendor-bin/test/vendor/bin/phpstan analyze -c phpstan.neon . --ansi",
"vendor-bin/phpstan/vendor/bin/phpstan analyze -c phpstan.neon . --ansi",
],
],
]);
Expand Down Expand Up @@ -141,7 +141,7 @@ function initializeLibrary (SymfonyStyle $io) : int
"vendor-bin/cs-fixer/vendor/bin/php-cs-fixer fix --diff --config vendor-bin/cs-fixer/vendor/21torr/php-cs-fixer/.php-cs-fixer.dist.php --dry-run --no-interaction --ansi",
],
"test" => [
"vendor-bin/test/vendor/bin/phpstan analyze -c phpstan.neon . --ansi",
"vendor-bin/phpstan/vendor/bin/phpstan analyze -c phpstan.neon . --ansi",
],
],
]);
Expand Down
5 changes: 3 additions & 2 deletions phpstan/lib.neon
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@ parameters:
checkUninitializedProperties: true
inferPrivatePropertyTypeFromConstructor: true
polluteScopeWithLoopInitialAssignments: false
reportPossiblyNonexistentConstantArrayOffset: true
reportPossiblyNonexistentGeneralArrayOffset: true
# as soon as PHPStan 1.11 is released
# reportPossiblyNonexistentConstantArrayOffset: true
# reportPossiblyNonexistentGeneralArrayOffset: true
reportUnmatchedIgnoredErrors: false
treatPhpDocTypesAsCertain: false

Expand Down