Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add semantic versioning (semver.org) validator #246

Merged
merged 4 commits into from
Apr 25, 2024
Merged

add semantic versioning (semver.org) validator #246

merged 4 commits into from
Apr 25, 2024

Conversation

thiagowfx
Copy link
Contributor

@thiagowfx
Copy link
Contributor Author

If you deem this PR worthwhile, please accept the workflow so that we can verify whether the tests pass.

@thiagowfx thiagowfx marked this pull request as ready for review April 22, 2024 13:53
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 23, 2024
View reviewed changes
yamale/validators/validators.py Dismissed Show dismissed Hide dismissed
@cblakkan
Copy link
Member

Looks like you've got a typo in the test


      def test_semver():
          """
          - https://semver.org/#is-there-a-suggested-regular-expression-regex-to-check-a-semver-string
          - https://regex101.com/r/Ly7O1x/3/
          """
  >       v = val.Semver()
  E       AttributeError: module 'yamale.validators' has no attribute 'Semver'. Did you mean: 'SemVer'?

@thiagowfx
Copy link
Contributor Author

Ooops! Fixed

@cblakkan cblakkan self-requested a review April 25, 2024 13:36
cblakkan
cblakkan reviewed Apr 25, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@cblakkan cblakkan merged commit 113e5b0 into 23andMe:master Apr 25, 2024
4 checks passed
emmeowzing referenced this pull request in premiscale/premiscale Jun 3, 2024
@emmeowzing
fix(deps): update dependency yamale to v5 (#180)
dc36ee3 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [yamale](https://togithub.com/23andMe/Yamale) | `^4.0.4` -> `^5.0.0` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/yamale/5.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/yamale/5.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/yamale/4.0.4/5.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/yamale/4.0.4/5.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [yamale](https://togithub.com/23andMe/Yamale) | `==4.0.4` -> `==5.2.1`
|
[![age](https://developer.mend.io/api/mc/badges/age/pypi/yamale/5.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/yamale/5.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/yamale/4.0.4/5.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/yamale/4.0.4/5.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>23andMe/Yamale (yamale)</summary>

### [`v5.2.1`](https://togithub.com/23andMe/Yamale/releases/tag/5.2.1)

[Compare
Source](https://togithub.com/23andMe/Yamale/compare/5.2.0...5.2.1)

##### What's Changed

- (fix)semver: SyntaxWarning: invalid escape sequence by
[@&#8203;kiblik](https://togithub.com/kiblik) in
[https://github.com/23andMe/Yamale/pull/248](https://togithub.com/23andMe/Yamale/pull/248)

##### New Contributors

- [@&#8203;kiblik](https://togithub.com/kiblik) made their first
contribution in
[https://github.com/23andMe/Yamale/pull/248](https://togithub.com/23andMe/Yamale/pull/248)

**Full Changelog**:
23andMe/Yamale@5.2.0...5.2.1

### [`v5.2.0`](https://togithub.com/23andMe/Yamale/releases/tag/5.2.0)

[Compare
Source](https://togithub.com/23andMe/Yamale/compare/5.1.0...5.2.0)

##### What's Changed

- Add CodeQL workflow for GitHub code scanning by
[@&#8203;lgtm-com](https://togithub.com/lgtm-com) in
[https://github.com/23andMe/Yamale/pull/205](https://togithub.com/23andMe/Yamale/pull/205)
- Add ruff gh action by
[@&#8203;cblakkan](https://togithub.com/cblakkan) in
[https://github.com/23andMe/Yamale/pull/244](https://togithub.com/23andMe/Yamale/pull/244)
- [#&#8203;236](https://togithub.com/23andMe/Yamale/issues/236) Hard
fail on undefined includes by
[@&#8203;cblakkan](https://togithub.com/cblakkan) in
[https://github.com/23andMe/Yamale/pull/247](https://togithub.com/23andMe/Yamale/pull/247)
- Add semantic versioning (semver.org) validator by
[@&#8203;thiagowfx](https://togithub.com/thiagowfx) in
[https://github.com/23andMe/Yamale/pull/246](https://togithub.com/23andMe/Yamale/pull/246)

##### New Contributors

- [@&#8203;lgtm-com](https://togithub.com/lgtm-com) made their first
contribution in
[https://github.com/23andMe/Yamale/pull/205](https://togithub.com/23andMe/Yamale/pull/205)
- [@&#8203;thiagowfx](https://togithub.com/thiagowfx) made their first
contribution in
[https://github.com/23andMe/Yamale/pull/246](https://togithub.com/23andMe/Yamale/pull/246)

**Full Changelog**:
23andMe/Yamale@5.1.0...5.2.0

### [`v5.1.0`](https://togithub.com/23andMe/Yamale/releases/tag/5.1.0)

[Compare
Source](https://togithub.com/23andMe/Yamale/compare/5.0.0...5.1.0)

##### What's Changed

- fix(cli): check schema to be a valid path first by
[@&#8203;AndreyNautilus](https://togithub.com/AndreyNautilus) in
[https://github.com/23andMe/Yamale/pull/241](https://togithub.com/23andMe/Yamale/pull/241)
- Ruff format codebase by
[@&#8203;cblakkan](https://togithub.com/cblakkan) in
[https://github.com/23andMe/Yamale/pull/243](https://togithub.com/23andMe/Yamale/pull/243)

##### New Contributors

- [@&#8203;AndreyNautilus](https://togithub.com/AndreyNautilus) made
their first contribution in
[https://github.com/23andMe/Yamale/pull/241](https://togithub.com/23andMe/Yamale/pull/241)

**Full Changelog**:
23andMe/Yamale@5.0.0...5.1.0

### [`v5.0.0`](https://togithub.com/23andMe/Yamale/releases/tag/5.0.0)

[Compare
Source](https://togithub.com/23andMe/Yamale/compare/4.0.4...5.0.0)

Supported python versions are now >= 3.8

##### What's Changed

- fix 3.12 deprecations by
[@&#8203;sigma67](https://togithub.com/sigma67) in
[https://github.com/23andMe/Yamale/pull/237](https://togithub.com/23andMe/Yamale/pull/237)
- Prep for 5.0.0; Run tests on 3.8, 3.12 by
[@&#8203;cblakkan](https://togithub.com/cblakkan) in
[https://github.com/23andMe/Yamale/pull/240](https://togithub.com/23andMe/Yamale/pull/240)

##### New Contributors

- [@&#8203;sigma67](https://togithub.com/sigma67) made their first
contribution in
[https://github.com/23andMe/Yamale/pull/237](https://togithub.com/23andMe/Yamale/pull/237)
- [@&#8203;cblakkan](https://togithub.com/cblakkan) made their first
contribution in
[https://github.com/23andMe/Yamale/pull/240](https://togithub.com/23andMe/Yamale/pull/240)

**Full Changelog**:
23andMe/Yamale@4.0.4...5.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [x] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/premiscale/premiscale).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblakkan cblakkan cblakkan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thiagowfx @cblakkan