Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding Task-Rui Song #1

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

RuiSong1998
Copy link

@RuiSong1998 RuiSong1998 commented Sep 9, 2024

1. Description

Completed UI (including animation and navigation through the MY RADICAL header button) and full functionalities (data fetching and rendering, form input validation and state management, etc. ) of the Next.js application.

2. How to Run

Cloning the Repository

git clone https://github.com/RuiSong1998/coding-task-rui-song.git
cd coding-task-rui-song

Installation

npm install

Set Up Environment Variables

Create a new file named .env in the root of the project and add the API key.

Running the Project

npm run dev

Open http://localhost:3000 in the browser to view the project.

3. Note

The API endpoint for all articles kept timing out, so I was only able to test with a few articles. Although the appilication runs well with the returned HTML strings of those articles, I assume there might be some articles that don't look perfect in the appilication.

@jimlambie
Copy link
Member

@RuiSong1998 thanks for this - I forgot about the possibility of a timeout with the all articles endpoint, in reality it should have a limit applied, for e.g. &limit=20

We'll give this a good look later today or tomorrow, feel free to continue committing if you feel the need to. Cheers!

@RuiSong1998
Copy link
Author

@jimlambie Thank you! I'll try with the limit and push some new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants