-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrisw coding task #1
Open
chriscodingxyz
wants to merge
16
commits into
27Works:master
Choose a base branch
from
chriscodingxyz:chrisw-coding-task
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tered header with username
…ble components updated, next config allowing for external images
…act-parser however still need to space out the <p> content within each bodyText
… tag, this gives it the 28px spacing between
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only thing that needs to be done is adding the "APIKEY" into .env file locally
I also added a preview.mp4 file in the public folder
I usually use shadcn for some component structuring and also the re-usable colors via vars. However tried not to use anything 27.works is not currently using. Also was not sure your approach for page/viewport breaks so I just did some basic responsiveness.
Mostly focused on the tasks in the pdf
Resisted breaking things down into smaller components as this was primarily 2 pages and did not want to have anyone searching for components and stylings
Please let me know if any changes need to be made