Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert className toString to work for SVGs #153

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Convert className toString to work for SVGs #153

wants to merge 4 commits into from

Conversation

BenjaminWaye
Copy link

No description provided.

BenjaminWaye
BenjaminWaye commented Jul 23, 2023
View reviewed changes
index.js Outdated Show resolved Hide resolved
BenjaminWaye
BenjaminWaye commented Jul 23, 2023
View reviewed changes
index.js Outdated Show resolved Hide resolved
@BenjaminWaye
Copy link
Author

This is an important fix. This is still broken when pressing on an SVG in the React tinder card

The SVG doesn't have className so instead null is sent which causes an exception. The solution is to getAttribute("class") instead.

@BenjaminWaye BenjaminWaye mentioned this pull request Aug 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BenjaminWaye