minor change

3dcitydb · Dec 2, 2023 · 35fc5c4 · 35fc5c4
1 parent e51a0eb
commit 35fc5c4
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 17 deletions.
diff --git a/citydb-cli/src/main/java/org/citydb/cli/deleter/DeleteCommand.java b/citydb-cli/src/main/java/org/citydb/cli/deleter/DeleteCommand.java
@@ -182,11 +182,10 @@ private DeleteOptions getExportOptions() {
     private void abort(long id, Throwable e) {
         synchronized (lock) {
             if (shouldRun) {
+                shouldRun = false;
                 logger.warn("Database delete aborted due to an error.");
                 helper.logException("Failed to delete feature (ID: " + id + ").", e);
             }
-
-            shouldRun = false;
         }
     }
 }
diff --git a/citydb-cli/src/main/java/org/citydb/cli/exporter/ExportController.java b/citydb-cli/src/main/java/org/citydb/cli/exporter/ExportController.java
@@ -186,21 +186,14 @@ protected WriteOptions getWriteOptions(DatabaseAdapter databaseAdapter) {
     private void abort(Feature feature, long id, Throwable e) {
         synchronized (lock) {
             if (shouldRun) {
-                String message;
-                if (feature == null) {
-                    message = "Failed to export feature (ID: " + id + ").";
-                } else {
-                    String objectId = feature.getObjectId().orElse(null);
-                    message = "Failed to export " + feature.getFeatureType().getLocalName() +
-                            (objectId != null ? " '" + objectId + "'" : "") +
-                            " (ID: " + id + ").";
-                }
-
+                shouldRun = false;
                 logger.warn("Database export aborted due to an error.");
-                helper.logException(message, e);
+                helper.logException(feature == null ?
+                        "Failed to export feature (ID: " + id + ")." :
+                        "Failed to export " + feature.getFeatureType().getLocalName() +
+                                feature.getObjectId().map(objectId -> " '" + objectId + "'").orElse("") +
+                                " (ID: " + id + ").", e);
             }
-
-            shouldRun = false;
         }
     }
 }
diff --git a/citydb-cli/src/main/java/org/citydb/cli/importer/ImportController.java b/citydb-cli/src/main/java/org/citydb/cli/importer/ImportController.java
@@ -211,12 +211,11 @@ protected ImportOptions getImportOptions() {
     private void abort(Feature feature, Throwable e) {
         synchronized (lock) {
             if (shouldRun) {
+                shouldRun = false;
                 logger.warn("Database import aborted due to an error.");
                 helper.logException("Failed to import " + feature.getFeatureType().getLocalName() +
                         " '" + feature.getObjectId().orElse("unknown ID") + "'.", e);
             }
-
-            shouldRun = false;
         }
     }
 }