-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tiling module and CLI options #41
Conversation
The following error was produced while running the import/export CLI command. The same command works well with the main branch. Is there anything I missed?
|
Hm, cannot reproduce. Maybe you can debug? |
Test again. I fixed the dependencies. |
Works now. What should the json config look like? for example in case of matrix tiling like this?
|
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice PR. One important remark is about the CRS of the TileMatrix.
citydb-tiling/src/main/java/org/citydb/tiling/options/DimensionScheme.java
Show resolved
Hide resolved
You have to add the "tiling":{
"scheme":{
"type":"Dimension",
"height":{
"value":1000.0
},
"width":{
"unit":"km",
"value":1.0
}
}
} or "tiling":{
"scheme":{
"type":"Matrix",
"columns":4,
"rows":4
}
} |
The TileMatrix produces the tiles which are used as spatial filter against the database. I think this should be done in the CRS of the database to avoid distortions. What would be the advantage of doing this in WGS84? |
Tiling based on the input SRS can provide a more generic way. One use case is the current VIS-Exporter, which ist based on the tiling in WGS84. Another case is for example the CRS used by the iUR data, which is a Geographic CRS. Tiling based an input projected CRS can avoid distortions if we want to export the data in a projected CRS. |
cool, works well. |
Tiling works in case the user provides the tiling extent in the database CRS or in any other CRS. The database CRS is only used internally for computing the tiles. These are the steps of the VIS export implementation of the old Importer/Exporter:
I think this is not a good example. The new API is much clearer in my opinion. |
The new API is clearer. Just hope it to be more generic to support tiling matrix with different CRS. like the old API |
Merging now. The extents of both the |
This PR adds a tiling module and API as well as corresponding tiling options to the CLI command.