Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ManualPicker: automatically save when closing the window #1028

Merged
merged 4 commits into from
Nov 28, 2023

Conversation

biochem-fan
Copy link
Member

ManualPicker says:

NOTE: in order to write the new list of coordinate STAR files, you need to re-count the particles or quite this program through the File menu. Do NOT kill the program using the operating system's window manager!

but this is not user-friendly. Most people don't notice this message, and even if they do see this, they just forget to use the menu.

With this patch, ManualPicker automatically saves the list even when closed by the window manager.

This also fixes a problem in the [File]-[Quit] menu. It used to save the list without recounting. Now it recounts and then saves the list.

@biochem-fan biochem-fan requested a review from scheres November 10, 2023 15:28
@scheres
Copy link
Contributor

scheres commented Nov 15, 2023

Hi Takanori,
Thanks for this suggestion, but could it be that this does not work? If I close the window from the desktop manager, the coordinates do still not get saved? Am I doing something wrong, and does this work on your system?
Sjors

@biochem-fan
Copy link
Member Author

@scheres Let's make sure we are looking at the same thing.

If I close the window from the desktop manager

I mean closing the micrograph list window (relion_manualpick) with the top right [X] button of the title bar. Are you closing the window in other ways?

the coordinates do still not get saved?

This patch is about automatically recounting and updating manualpick.star, which contains the list of micrographs with picked particles, upon closing relion_manualpick. This does not automatically save picked coordinates in individual micrograph view (relion_display).

@scheres scheres merged commit 8f1883a into ver5.0 Nov 28, 2023
0 of 4 checks passed
@biochem-fan
Copy link
Member Author

@scheres Do we want to auto-save picking results on individual micrographs (i.e. relion_display)?
If so, you can use a closing callback as in dd7d056.

@scheres
Copy link
Contributor

scheres commented Nov 29, 2023

That would be nice. I tried this actually yesterday, but could not make it work, as the picker uses a separated canvas. Perhaps you're better at this. But it is not too high on the priority list... People rarely pick manually these days.

@biochem-fan
Copy link
Member Author

It is hard to force relion_manualpick to recount particles when new coordinates are saved by relion_display. This needs an inotify mechanism. On the other hand, it is easy to auto-save coordinates in relion_display. However, I am not sure if this is desirable. People might accidentally click on a micrograph when inspecting AutoPick results. Such changes are discarded unless users explicitly save them. Do we want to automatically save instead?

@scheres
Copy link
Contributor

scheres commented Nov 29, 2023

OK, let's just leave it as it is. Thanks!

@biochem-fan
Copy link
Member Author

If we decide so, perhaps your commit b8cbd4f should be reverted for consistency.

@scheres
Copy link
Contributor

scheres commented Nov 29, 2023

ok, done.

@scheres scheres deleted the manualpick_autosave branch November 29, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants