Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repair InitialModel Job to apply C10,C11...C19 symmetry when requested #1071

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

huwjenkins
Copy link
Contributor

fixes #1070

Fix also required in ver5.0 branch.

…d after initial model run without applying symmetry
@biochem-fan biochem-fan changed the base branch from master to ver4.0 January 23, 2024 06:16
@biochem-fan biochem-fan changed the base branch from ver4.0 to master January 23, 2024 06:17
@biochem-fan biochem-fan changed the base branch from master to ver5.0 January 23, 2024 06:19
@biochem-fan biochem-fan merged commit 7088a37 into 3dem:ver5.0 Jan 23, 2024
0 of 4 checks passed
@biochem-fan
Copy link
Member

biochem-fan commented Jan 23, 2024

Thank you very much.

I noticed that our master branch is RELION 5.0 beta now. This should remain RELION 4.0 until RELION 5.0 stable is released. @scheres, is this intentional?

Anyway, I merged your pull request to the ver5.0 branch and cherry-picked it into the ver4.0 branch as well. The master branch remains unfixed until we decide which version it should host.

@biochem-fan
Copy link
Member

The master branch was reverted to RELION 4.0 (with force push, unfortunately). Now all of master, ver4.0, ver5.0 have your fix.

@huwjenkins
Copy link
Contributor Author

Apologies for the confusion!

I merged your pull request to the ver5.0 branch and cherry-picked it into the ver4.0 branch as well

Thanks! I will try to remember to raise PRs from the verX.0 branch in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants