Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 4391- Federation groups #4445

Merged
merged 58 commits into from
Oct 13, 2023
Merged

Issue 4391- Federation groups #4445

merged 58 commits into from
Oct 13, 2023

Conversation

carmenfan
Copy link
Member

@carmenfan carmenfan commented Sep 7, 2023

This fixes #4391

Description

New functionality added:

  • The ability to assign groups to containers with a federation
    • schema has been altered to store this information in federation settings
    • swagger has been updated to reflect the new schema
  • The ability to render the groups correctly in the tree

Test cases

  • v4
    • Can edit federations (pre/post migration)
    • Can create federation
    • Can import BCF
    • account list is correct
  • v5
    • Delete container - submodel check should function as before
    • Get TicketGroupByID should work as before (for purposes of getting ids from submodels)
    • GetModelStats should work
    • Can edit federations (pre/post migration)

@carmenfan carmenfan marked this pull request as ready for review October 9, 2023 14:05
@Charence
Copy link
Contributor

Charence commented Oct 9, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

sanmont3drepo
sanmont3drepo previously approved these changes Oct 11, 2023
@carmenfan carmenfan assigned carmenfan and unassigned sanmont3drepo Oct 12, 2023
@Charence
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Charence Charence merged commit ca36128 into staging Oct 13, 2023
10 checks passed
@Charence Charence deleted the ISSUE_4391 branch October 13, 2023 10:25
@carmenfan carmenfan removed their assignment Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants