ISSUE 4628 - Model Loading Speed Improvements #4629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-gzipped. This is for testing and needs to be updated to depend on db.
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@Charence, I uploaded these this morning: https://issue-4628.dev.3drepo.io/v5/dashboard/MeshOptWorkspace/e116e566-85d2-48f2-a778-e0077fed248e/t/containers If you can get a couple of the asset bundles from the ref nodes, I can check if they are gzipped properly and therefore if the issue is with the bouncer or .io? |
…provided by the ref node in the database. Updated unity asset bundles route to use the new FilesManager to return the bundle.
…used mime type.
carmenfan
previously approved these changes
Dec 7, 2023
There was a problem hiding this comment.
This works fine, the only issue I find is that we don't cancel the background fetches when we leave the page:
This could be problematic if the user entered a container and start fetching thousands of bundles.... But I don't think this is release critical and it could be something we address in 5.8 if it's complex (if so, please create an issue) - so approving for now!
…instead of enumerating Scene nodes in assetsMeta to improve performance on large models
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
carmenfan
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4628
Description
This PR is created right now to get a deployment so we can benchmark against one without any fixes.
Test cases