-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE 4628 - Model Loading Speed Improvements #4629
Conversation
…-gzipped. This is for testing and needs to be updated to depend on db.
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
@Charence, I uploaded these this morning: https://issue-4628.dev.3drepo.io/v5/dashboard/MeshOptWorkspace/e116e566-85d2-48f2-a778-e0077fed248e/t/containers If you can get a couple of the asset bundles from the ref nodes, I can check if they are gzipped properly and therefore if the issue is with the bouncer or .io? |
…provided by the ref node in the database. Updated unity asset bundles route to use the new FilesManager to return the bundle.
…used mime type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works fine, the only issue I find is that we don't cancel the background fetches when we leave the page:
This could be problematic if the user entered a container and start fetching thousands of bundles.... But I don't think this is release critical and it could be something we address in 5.8 if it's complex (if so, please create an issue) - so approving for now!
…instead of enumerating Scene nodes in assetsMeta to improve performance on large models
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
This fixes #4628
Description
This PR is created right now to get a deployment so we can benchmark against one without any fixes.
Test cases