-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 5099 - Ticket Image List (frontend) #5117
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The-Daniel
reviewed
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but I can't seem to get the image list in tabular view
we'll leave this as draft until #5091 is merged |
The-Daniel
previously approved these changes
Sep 19, 2024
sanmont3drepo
requested changes
Sep 19, 2024
frontend/src/v5/ui/controls/imageWithExtraCount/imageWithExtraCount.component.tsx
Show resolved
Hide resolved
frontend/src/v5/ui/controls/imageWithExtraCount/imageWithExtraCount.component.tsx
Show resolved
Hide resolved
...i/routes/viewer/tickets/ticketsForm/properties/ticketImageList/ticketImageList.component.tsx
Outdated
Show resolved
Hide resolved
sanmont3drepo
requested changes
Sep 24, 2024
...i/routes/viewer/tickets/ticketsForm/properties/ticketImageList/ticketImageList.component.tsx
Show resolved
Hide resolved
sanmont3drepo
requested changes
Sep 24, 2024
...i/routes/viewer/tickets/ticketsForm/properties/ticketImageList/ticketImageList.component.tsx
Show resolved
Hide resolved
sanmont3drepo
approved these changes
Sep 27, 2024
sanmont3drepo
approved these changes
Sep 27, 2024
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
The-Daniel
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5099
Description
Added a new ticket property. The backend for this is not yet ready, so to test this, find attached a patch for templates selector.
The property should allow to edit/delete one/delete all/upload one or more images.
The disabled property should not allow for any of these actions.
The change of the value should only happen when all the images are deleted (ellipsis menu) or in batch, when closing the modal. This is to ensure that, if the property is set to immutable, the user is still able to edit the images
Test cases
Snippet to add image list property
export const selectTemplateById = createSelector( selectTicketsDomain, selectTemplates, (state, modelId, templateId) => templateId, (state, templates, templateId) => { const t = templates.find(({ _id }) => _id === templateId); if (!t) return null; return { ...t, properties: t.properties.concat({ type: 'imageList', name: 'Image List', }), }; }, );