Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 5099 - Ticket Image List (frontend) #5117

Merged
merged 18 commits into from
Sep 27, 2024
Merged

Issue 5099 - Ticket Image List (frontend) #5117

merged 18 commits into from
Sep 27, 2024

Conversation

Amantini1997
Copy link
Contributor

This fixes #5099

Description

Added a new ticket property. The backend for this is not yet ready, so to test this, find attached a patch for templates selector.

The property should allow to edit/delete one/delete all/upload one or more images.
The disabled property should not allow for any of these actions.
The change of the value should only happen when all the images are deleted (ellipsis menu) or in batch, when closing the modal. This is to ensure that, if the property is set to immutable, the user is still able to edit the images

Test cases

Snippet to add image list property export const selectTemplateById = createSelector( selectTicketsDomain, selectTemplates, (state, modelId, templateId) => templateId, (state, templates, templateId) => { const t = templates.find(({ _id }) => _id === templateId); if (!t) return null; return { ...t, properties: t.properties.concat({ type: 'imageList', name: 'Image List', }), }; }, );

Copy link
Contributor

@The-Daniel The-Daniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I can't seem to get the image list in tabular view

@sanmont3drepo sanmont3drepo marked this pull request as draft August 23, 2024 13:47
@sanmont3drepo
Copy link
Contributor

we'll leave this as draft until #5091 is merged

@sanmont3drepo sanmont3drepo marked this pull request as ready for review September 17, 2024 12:34
The-Daniel
The-Daniel previously approved these changes Sep 19, 2024
@sanmont3drepo sanmont3drepo removed the request for review from The-Daniel September 27, 2024 11:29
@Charence
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@sanmont3drepo sanmont3drepo merged commit adac12d into staging Sep 27, 2024
21 of 24 checks passed
@sanmont3drepo sanmont3drepo deleted the ISSUE_5099 branch September 27, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants