ISSUE #5163 Vertical range and units stored in model settings #5165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unit and e2e test adjustments documentation adjustment
carmenfan
requested changes
Sep 19, 2024
...d/src/v5/middleware/dataConverter/inputs/teamspaces/projects/models/commons/modelSettings.js
Outdated
Show resolved
Hide resolved
backend/src/v5/processors/teamspaces/projects/models/drawings/calibrations.js
Outdated
Show resolved
Hide resolved
backend/src/v5/routes/teamspaces/projects/models/drawings/calibrations.js
Outdated
Show resolved
Hide resolved
...d/src/v5/middleware/dataConverter/inputs/teamspaces/projects/models/drawings/calibrations.js
Outdated
Show resolved
Hide resolved
carmenfan
requested changes
Sep 23, 2024
backend/src/v5/processors/teamspaces/projects/models/drawings/calibrations.js
Outdated
Show resolved
Hide resolved
backend/tests/v5/unit/processors/teamspaces/projects/models/drawings/calibrations.test.js
Outdated
Show resolved
Hide resolved
backend/tests/v5/unit/processors/teamspaces/projects/models/drawings/calibrations.test.js
Outdated
Show resolved
Hide resolved
carmenfan
requested changes
Sep 26, 2024
carmenfan
reviewed
Sep 26, 2024
carmenfan
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5163
Description
Vertical range and units are no longer stored in calibrations but in model settings
Get Calibration retrieves the info from model settings document
Adding a new drawing requires the calibration info
Adding a new calibration updates model settings
Geting model settings info returns the calibration info too
Unit and E2E tests updated
Documentation updates
Test cases
Getting a calibration shoud not change the returned data
Getting model settings should also return the calibration info
Adding a new calibration should update the model settings document with the new data