Issue 5143 - Clear console warnings #5190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanmont3drepo
requested changes
Oct 10, 2024
frontend/src/v4/routes/viewerGui/components/reportedItems/reportedItems.component.tsx
Outdated
Show resolved
Hide resolved
frontend/src/v5/ui/routes/viewer/tickets/ticketsForm/commentsPanel/commentsPanel.component.tsx
Show resolved
Hide resolved
...iewer/tickets/ticketsForm/properties/viewerInputContainer/viewerInputContainer.component.tsx
Show resolved
Hide resolved
The-Daniel
requested changes
Oct 11, 2024
There was a problem hiding this comment.
Errors in invitationDialog (When adding a user to a teamspace and you click the job select).
I think this is due to the error={form.errors.email} on line 202.
There was a problem hiding this comment.
On closing this modal you get this error:
(I get this when closing various v4 modals)
There was a problem hiding this comment.
The second one is an actual error and, unfortunately, is triggered by MUI, so it won't be fixed
There was a problem hiding this comment.
I don't know if I fixed it somehow, but I can't reproduce this one Errors in invitationDialog (When adding a user to a teamspace and you click the job select).
Can you record the steps?
The-Daniel
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5143
Description
I got rid of all the warnings printed as errors that I have bumped into. I might be missing still some though, so feel free to raise list them in case
Test cases
Navigate around the app and play with the different components. No warnings should be printed (as error)