Issue 5223 Release candidate 5.12.0

[carmenfan]

This fixes #5223

Issues addressed:

https://github.com/3drepo/3drepo.io/milestone/268
https://github.com/3drepo/3drepo.io/milestone/271

Test cases

Full QA test should pass: https://asitesol.sharepoint.com/:x:/s/3DRepoTeamFolder/EYiaHuA-Y5ZBligBNUw4u1kBB-WUG6pZFGWkVfmFJnWLMw?e=2ff05f

Bug template

### Description
<!-- Brief description of the bug -->

### Steps to replicate

### Current Behaviour

### Expected Behaviour

### Pictures/ Gifs of the error

Next bug to triage: #5224 (comment)

Bugs

• Teamspace not found error is popping up when you update your profile
• Sometimes dragging camera result in the picture moving instead (Alessandro)
• Group import error dialog is saying export error (Daniel)
• Too high momentum when dragging the 2D Drawing (Daniel)

Graphics:

• Pin is disappearing on certain angle

Round 1

Release Critical

Frontend

• Sort by calibration order does not change when you alter the sort (Alessandro)
• Version number links to Intercom Help home rather than Change Logs page (Daniel)
• Vertical calibration fields are not disabled if the user doesn't have sufficient privilege to update them (Daniel)
• Collaborators are getting an error when they try to upload a drawing. (Alessandro)
• Can't save a ticket that has a view with transformations (Daniel)
• Sorting of federations by tickets doesnt work correctly (Alessandro)
• Changing the code of a federation from something to empty, the list doesn't reflect it and editing still shows the old code. (Alessandro)
• White screen when you delete the last image from a text comment in a ticket (Daniel)
• Opacity is not being respected in v4 groups (Alessandro)
• Viewer whitescreens if I change revision after selecting a group (Daniel)
• The 'close 2D' circle button is appearing during calibration which is unnecessary as there is already a cancel calibration button (Daniel)
• Clipping is not available when calibrating (Daniel)
  • Duplicate: I dont know if this is an issue, but when I change the the containers included It doesnt update last updated
• Viewer occasionally crashes when trying to recalibrate from the dashboard. (Alessandro - cannot reproduce)
• Drawing filename is getting overwritten (Daniel)

Unity

• Tree behaves strangely on this federation (Sebastian; https://github.com/3drepo/3drepounity/pull/555)

Backend

• Drawings are being downloaded with the statusCode-Revision code as the name of the file instead of the original file name (Carmen)
• Refreshing page during drawing queue for processing makes the new revision disappear (Carmen)
  • Duplicate: Issue 5223 Release candidate 5.12.0 #5224 (comment)

Highly desired

• Broken link in Terms (Carmen)
• Typo in Cookies (Carmen)
• User list page is visible even though you're not a teamspace admin (Alessandro)
  • duplicate: Issue 5223 Release candidate 5.12.0 #5224 (comment)
• Update/Add project image fails on images over 1MB. Images under that seem to work. (Alessandro)
• Socket.io groups messages doesn't seem to be registering if I've viewed a different model previously. (Alessandro)
• Upload modals (drawings/containers) are using metric file sizes whereas everywhere else on the app we use IEC units. (Alessandro)

Nice to have

• Add user button should look disabled when it is (Daniel)
• Setting opacity causes shapes to be filled in. (Alessandro)
• Gis survey point doesnt reflect when changed except for angle. Description and code cant get blanked also. (Daniel)

Lower priority nice to have

• Update button stays active when you upload a new avatar (Daniel)
• Clip plane border width setting does not work. (Daniel)
• Cannot add new issue types/risk categories (Can't reproduce - Daniel)
• Updating GIS settings hides tiles
  (Daniel)
• Markup triangle does not fit transform box (Alessandro)

Won't fix

• Intercom layout is a bit odd
• Issues filter list container too small, even when there are no issues.
  
• No spacing below long Description strings in issue.
• The frontend attempts to read fulltree.json for empty containers, and containers it does not have access to when loading a federation.
• Issues 4D dialog should not allow setting start date after end date, or end date before start date.
• When closing an issue, shapes are not removed until the issue exits.
• Internal server error when trying to load Here Map Tiles
• Unreal readme is incorrect
• clipping is not available when calibrating. I think this comes from the design change that when you create a drawing there are default planes values.
• The user can calibrate a drawing against a federation of empty containers. Other forms of empty model are hidden in this dropdown

Expected behaviour

• Unable to drag and drop a risk
• Drawing revisions can have the same Revision Code but should not.
• No option to download the Risk report in any other format than JSON.
  
• The last two tests in "Viewer - Risks" ask to set the treatment status to "fully treated". This option is missing from the dropdown.
• There is no Create Report option for Issues
• Focus button not visible on toolbar
  

Queue issues

Same queue serving multiple branches is causing these issues:

• Issue 5223 Release candidate 5.12.0 #5224 (comment)

[The-Daniel]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[The-Daniel]

Description

Dragging the camera in the 2D viewer occasionally switches to dragging the picture instead.
I think this usually happens when dragging the camera outside the bounds of the drawing.

Steps to replicate

Open a calibrated drawing in the viewer
Zoom out in the 2D viewer
Grab the camera and move it around outside of the drawing

Current Behaviour

The dragged object will randomly change from the camera to the drawing

Expected Behaviour

The dragged object remains the camera

Pictures/ Gifs of the error

Recording.2024-10-24.150412.mp4

[carmenfan]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[carmenfan]

Description

Teamspace not found error is popping up when you update your profile

Steps to replicate

• Go onto profile and edit surname
• Click save

Current Behaviour

Profile saves correctly, but a error modeal about teamspace not found is popping up

Network tab indicates that we're trying to call teamspace members API for some reason:

Expected Behaviour

Should not be calling members endpoint

Pictures/ Gifs of the e

rror

[carmenfan]

Description

Error on group import is showing a modal with export groups in the text

Steps to replicate

• trigger an error on the group import

Current Behaviour

• error modal is saying there's an error exporting the group

Expected Behaviour

• should be error importing the groups

Pictures/ Gifs of the error

[carmenfan]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[carmenfan]

Description

Too high momentum when dragging the 2D Drawing

Can we increase the inertia? This is too out of control:

I clicked and dragged by only a small amount with the intention of just moving the drawing slightly, but it's flying to the other side.

[carmenfan]

Description

Pin is disappearing on certain angle

Steps to replicate

• Go here https://issue-5223.dev.3drepo.io/v5/viewer/5_12_qa/cf224468-e8ad-4de7-adfd-a018fcf953e7/06868893-c1e0-4c7f-a906-809c558dc925?drawingId=d97caafe-ada2-4ebb-b59e-df86b8ccc8a1&ticketId=3ccced35-05ff-4b07-8e6e-275f294553c4

• Observe the red pin on the roof

Current Behaviour

At certain camera angles it's not showing up

Expected Behaviour

It should always show

Pictures/ Gifs of the error