Skip to content

Commit

Permalink
Merge branch 'staging' into ISSUE_654
Browse files Browse the repository at this point in the history
  • Loading branch information
carmenfan committed Dec 15, 2023
2 parents ce6315f + 5755809 commit 17ff62a
Show file tree
Hide file tree
Showing 8 changed files with 7 additions and 516 deletions.
1 change: 0 additions & 1 deletion tools/bouncer_worker/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
"crypto-js": "4.1.1",
"elastic-apm-node": "3.41.1",
"moment": "2.29.1",
"mongodb": "3.6.6",
"systeminformation": "5.6.20",
"tree-kill": "1.2.2",
"uuid": "8.3.2",
Expand Down
3 changes: 0 additions & 3 deletions tools/bouncer_worker/src/lib/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@ const applyDefaultValuesIfUndefined = (config) => {
config.rabbitmq.maxWaitTimeMS = config.rabbitmq.maxWaitTimeMS || 5 * 60 * 1000;
config.rabbitmq.waitBeforeShutdownMS = config.rabbitmq.waitBeforeShutdownMS || 60000;

// toy project configurations
config.toyModelDir = config.toyModelDir || path.resolve(__dirname, '../../toy');

// logging related
config.logging = config.logging || {};
config.logging.taskLogDir = config.logging.taskLogDir || config.bouncer.log_dir || config.rabbitmq.sharedDir;
Expand Down
11 changes: 0 additions & 11 deletions tools/bouncer_worker/src/lib/messageDecoder.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,6 @@ const messageDecoder = (cmd) => {
const args = replaceSharedDirPlaceHolder(cmd).split(/\s+/);
res = { command: args[0] };
switch (args[0]) {
case 'importToy':
res = {
command: args[0],
database: args[1],
model: args[2],
toyModelID: args[3],
user: args[1],
skipPostProcessing: (args[4] && JSON.parse(args[4])) || {},
};
break;
case 'import':
{
// eslint-disable-next-line
Expand All @@ -73,7 +63,6 @@ const messageDecoder = (cmd) => {
cmdParams: [configPath, ...args],
database: cmdFile.database,
model: cmdFile.project,
toyFed: cmdFile.toyFed,
user: cmdFile.owner,
...res,
};
Expand Down
47 changes: 7 additions & 40 deletions tools/bouncer_worker/src/queues/jobQueueHandler.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,54 +20,27 @@ const {
jobQueueSpecified,
logDirExists,
sharedDirExists } = require('./common');
const { importToyModel, validateToyImporterSettings } = require('../tasks/importToy');
const { ERRCODE_OK, ERRCODE_TOY_IMPORT_FAILED } = require('../constants/errorCodes');
const { ERRCODE_OK } = require('../constants/errorCodes');
const { config } = require('../lib/config');
const { generateTreeStash, runBouncerCommand } = require('../tasks/bouncerClient');
const { runBouncerCommand } = require('../tasks/bouncerClient');
const { messageDecoder } = require('../lib/messageDecoder');
const logger = require('../lib/logger');

const Handler = {};

const logLabel = { label: 'JOBQ' };

const importToy = async ({ database, model, toyModelID, skipPostProcessing }, logDir) => {
const returnMessage = {
value: ERRCODE_OK,
database,
project: model,
};

try {
await importToyModel(toyModelID, database, model, skipPostProcessing);

if (!skipPostProcessing.tree) {
logger.info('Toy model imported. Generating tree...', logLabel);
await generateTreeStash(logDir, database, model, 'tree');
}
} catch (err) {
logger.error(`importToy module error: ${err.message || err}`, logLabel);
returnMessage.value = ERRCODE_TOY_IMPORT_FAILED;
returnMessage.message = err.message || err;
}

return returnMessage;
};

const createFed = async ({ database, model, toyFed, cmdParams }, logDir) => {
const createFed = async ({ database, model, cmdParams }, logDir) => {
const returnMessage = {
value: ERRCODE_OK,
database,
project: model,
};
try {
returnMessage.value = await runBouncerCommand(logDir, cmdParams);
if (toyFed) {
await importToyModel(toyFed, database, model, { tree: 1 });
}
} catch (err) {
logger.error(`Error generating federation: ${err.message || err}`, logLabel);
returnMessage.value = toyFed ? ERRCODE_TOY_IMPORT_FAILED : err;
returnMessage.value = err;
returnMessage.message = err.message || err;
}

Expand All @@ -83,19 +56,13 @@ Handler.onMessageReceived = async (cmd, rid, callback) => {
return;
}

if (cmdMsg.command === 'importToy') {
const message = await importToy(cmdMsg, logDir);
callback(JSON.stringify(message));
} else {
const message = await createFed(cmdMsg, logDir);
callback(JSON.stringify(message));
}
const message = await createFed(cmdMsg, logDir);
callback(JSON.stringify(message));
};

Handler.validateConfiguration = (label) => logDirExists(label)
&& jobQueueSpecified(label)
&& sharedDirExists(label)
&& callbackQueueSpecified(label)
&& validateToyImporterSettings();
&& callbackQueueSpecified(label);

module.exports = Handler;
45 changes: 0 additions & 45 deletions tools/bouncer_worker/src/scripts/rename_toy.js

This file was deleted.

Loading

0 comments on commit 17ff62a

Please sign in to comment.