Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance on the BIM import class #416

Open
har00n-haider opened this issue Dec 11, 2020 · 0 comments
Open

Maintenance on the BIM import class #416

har00n-haider opened this issue Dec 11, 2020 · 0 comments

Comments

@har00n-haider
Copy link
Contributor

bouncer/src/repo/manipulator/modelconvertor/import/repo_model_import_3drepo.h

  • Update the way material nodes are created to remove the need for cloning them. Geometry would have to be parsed first
  • convert JSON attributes to enums so that they can be switched on for quicker and cleaner code
  • make sure that dynamically allocated memory is cleaned up in the destructor of the class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant