-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 391: Adding BIM3 support to bouncer #402
Conversation
…on, so explicitly included the relevant for for error codes
…string char pointer. putting the variable memory on the stack is it is not used elsewhere.
…'t break things as fin get reset by the end of the function)
…ng paths for compatability with Unix.
@carmenfan, ready for review. Quick summary:
|
@carmenfan , have removed the verbosity from the st/ut and the related logging functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@har00n-haider looks fine in general, just some minor clean up related stuff!
bouncer/src/repo/manipulator/modelconvertor/import/repo_model_import_3drepo.cpp
Outdated
Show resolved
Hide resolved
bouncer/src/repo/manipulator/modelconvertor/import/repo_model_import_3drepo.cpp
Outdated
Show resolved
Hide resolved
bouncer/src/repo/manipulator/modelconvertor/import/repo_model_import_3drepo.cpp
Outdated
Show resolved
Hide resolved
bouncer/src/repo/manipulator/modelconvertor/import/repo_model_import_3drepo.cpp
Outdated
Show resolved
Hide resolved
bouncer/src/repo/manipulator/modelconvertor/import/repo_model_import_3drepo.cpp
Outdated
Show resolved
Hide resolved
bouncer/src/repo/manipulator/modelconvertor/import/repo_model_import_3drepo.cpp
Outdated
Show resolved
Hide resolved
@carmenfan , feedback from the review has been implemented ready for another look! |
@carmenfan changes are completed |
Implements the BIM file format changes mentioned in #391