Issue 391: Adding BIM3 support to bouncer #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
November 6, 2020 13:00
…on, so explicitly included the relevant for for error codes
…string char pointer. putting the variable memory on the stack is it is not used elsewhere.
17 tasks
added 13 commits
November 12, 2020 09:24
…'t break things as fin get reset by the end of the function)
added 8 commits
November 13, 2020 18:02
…ng paths for compatability with Unix.
har00n-haider
commented
Nov 30, 2020
|
@carmenfan, ready for review. Quick summary:
|
har00n-haider
changed the title
carmenfan
reviewed
Nov 30, 2020
|
@carmenfan , have removed the verbosity from the st/ut and the related logging functions. |
carmenfan
requested changes
Dec 7, 2020
There was a problem hiding this comment.
@har00n-haider looks fine in general, just some minor clean up related stuff!
bouncer/src/repo/manipulator/modelconvertor/import/repo_model_import_3drepo.cpp
Outdated
Show resolved
Hide resolved
bouncer/src/repo/manipulator/modelconvertor/import/repo_model_import_3drepo.cpp
Outdated
Show resolved
Hide resolved
bouncer/src/repo/manipulator/modelconvertor/import/repo_model_import_3drepo.cpp
Outdated
Show resolved
Hide resolved
bouncer/src/repo/manipulator/modelconvertor/import/repo_model_import_3drepo.cpp
Outdated
Show resolved
Hide resolved
bouncer/src/repo/manipulator/modelconvertor/import/repo_model_import_3drepo.cpp
Outdated
Show resolved
Hide resolved
bouncer/src/repo/manipulator/modelconvertor/import/repo_model_import_3drepo.cpp
Outdated
Show resolved
Hide resolved
added 2 commits
December 11, 2020 10:03
|
@carmenfan , feedback from the review has been implemented ready for another look! |
carmenfan
requested changes
Dec 11, 2020
|
@carmenfan changes are completed |
carmenfan
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the BIM file format changes mentioned in #391