Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 639 - Federation group support #642

Merged
merged 5 commits into from
Oct 9, 2023
Merged

Issue 639 - Federation group support #642

merged 5 commits into from
Oct 9, 2023

Conversation

carmenfan
Copy link
Member

@carmenfan carmenfan commented Sep 12, 2023

This fixes #639

Description

This issue is to change the federation scene graph to match what we have proposed in 3drepo/3drepo.io#4391:

  • Removed the parent transformation before a ref node (it's always an identity matrix due to the way we create federation)
  • Instead, take in a set of reference nodes and its group name (if any)
  • turn group name into parenting transformation nodes, if there is none, wire the ref node to the root node.

Test cases

  • Should continue to produce working federations
  • Should be able to create groupings to group submodels under the same branch
  • Submodel references should be wired to the root node they do not belong in a grouping.

@carmenfan carmenfan assigned carmenfan and unassigned sebjf Sep 22, 2023
@carmenfan carmenfan merged commit b93c57c into staging Oct 9, 2023
1 check passed
@carmenfan carmenfan removed their assignment Oct 11, 2023
@carmenfan carmenfan deleted the ISSUE_639 branch March 6, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants