ISSUE #515 FBX rotated on axis #668
Conversation
Assimp supported model file rotation is done by file model convertor available in global settings. We need to upgrade assimp library to at least 5.X.X version for fetching "GlobalSetting" from assimp file. I have done with following assimp branch https://github.com/assimp/assimp/tree/v5.3.1
Do changes to handle rotation for FBX file only, other file working as it is.
bouncer/src/repo/manipulator/modelconvertor/import/repo_model_import_assimp.cpp
Outdated
Show resolved
Hide resolved
bouncer/src/repo/manipulator/modelconvertor/import/repo_model_import_manager.cpp
Outdated
Show resolved
Hide resolved
Remove extra code for FBX file checking as suggested by carmen. Keeping the code to check for FBX file, to handle rotation in other 3d file.
There was a problem hiding this comment.
@vmavadiya can you figure out when this is fixed and try a earlier version of assimp?
It's utilisiin string_view which is supported in c++17.
we're still building with c++14 support and upgrading to c++17 is going to be a massive project as some of our other dependencies doesn't like that. So It'd be useful to figure out how far back we can go until vc140/c++14 compiles.
@carmenfan The issue was resolved in 5.x.x version with following commit in assimp assimp/assimp#2293. And we have used version 5.0.0 of assimp, which is complied with C++14 and working fine. |
This fixes #515
Description
Assimp supported model file rotation is done by file model convertor available in global settings.
We need to upgrade assimp library to at least 5.X.X version for fetching "GlobalSetting" from assimp file.
I have done with following assimp branch https://github.com/assimp/assimp/tree/v5.3.1