ISSUE #664 Remove redundant transformation that is preventing metadata from referencing the right object #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #664
Description
Turns out we already optimise the first level of transformation. The problem lies on the model exporter in the plugins (issue addressed here https://github.com/3drepo/3drepoPlugin/issues/435) - for a node with geometry, it is exporting 2 transformations and a mesh....
To fix any existing .bim files or users using an older version of the plugins, the following change is made here:
Test cases
Test case described in 664 should now function as expected