Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 675 - do not write UV channel count if we're not writing UVs #676

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

carmenfan
Copy link
Member

@carmenfan carmenfan commented Feb 14, 2024

This fixes #675

Description

Fixes a bug when Synchro importer sometimes gives us empty UV channels, we are not storing an empty buffer to match but the UV channel is still recorded as > 0

Test cases

the 2 models in the sharepoint folder should now import successfully.

@carmenfan carmenfan merged commit 47ff664 into master Feb 15, 2024
4 checks passed
@carmenfan carmenfan deleted the ISSUE_675 branch March 6, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discrepancy between UV channel size value and the actual values in the buffer
3 participants