Issue 666 - add support for RepoBundles #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l be dealing with it even more in bouncer now
…since these are now used in computations so they should never be nan
…ation by value since it will only be a float or double, and allows avoiding the min max initialiser lists
…, but for bouncer by default to write assetbundles
…f file before any directory changes
…value as error to gxx flags.
…way of doing it
carmenfan
requested changes
Feb 28, 2024
bouncer/src/repo/manipulator/modelconvertor/export/repo_model_export_asset.cpp
Show resolved
Hide resolved
bouncer/src/repo/manipulator/modelconvertor/import/repo_model_import_assimp.cpp
Outdated
Show resolved
Hide resolved
| @@ -157,7 +157,14 @@ repo::core::model::MeshNode MeshMapReorganiser::getRemappedMesh() const | |||
| bboxArr.push_back({ bbox[1].x, bbox[1].y, bbox[1].z }); | |||
| } | |||
|
|
|||
| auto newMesh = repo::core::model::RepoBSONFactory::makeMeshNode(newVertices, newFaces, newNormals, bboxArr, newUVs, newColors); | |||
| auto submeshIds = getIDMapArrays(); | |||
There was a problem hiding this comment.
Not something to address here, just noting down my thoughts.
Stash graph and this should probably merge into 1 in the future? We're effectively batching the meshes twice 😆
… bbs should be initialised to -FLT_MAX)
… lists to a seperate collection
carmenfan
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #666 - Add support for RepoBundles
Description
This PR contains mainly minor changes required to integrate AssetGenerator.
AssetGenerator is an optional dependency that can be turned off (turned on by default) with the
REPO_ASSETGENERATOR_SUPPORTCMake flag. AssetGenerator will createRepoBundles, which are documented its own repository, after the stash scene is created.The changes made to bouncer to support this are:
MeshNode_RepoVector3Dconstructor has been adjusted so it can be initialised by value (it makes a copy of the reference immediately anyway), and the type has been given two new members.repo_color4d_thas been given new members.PropertyTree::addToTreehas support forrepo_color4d_tadded.