-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 679 - Add support for DWG importer #680
Conversation
…r separate from FileProcessorDgn
…lementation detail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General seems ok (as far as I can tell with the very small amount of dwg models I have!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine and good to merge
Just waiting on #685 so we can merge that in first (incase we need to do a hotfix!)
Issue 667 - New error code for encrypted NWDs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebjf travis is upset after merge from staging 😢
@carmenfan fixed! |
This fixes #679 - DWG object handles do not match Navis.
This PR adds a dedicated DWG importer using the Drawings SDK, replacing the previous importer which converted the DWG to a DGN, and then imported that using the DGN importer.
The new importer preserves the Handle Ids from AutoCAD, and better matches the Navisworks tree.
Description
New classes
FileProcessor
reads the file into anOdDatabase
, which is then vectorised by a Graphics System View subclass (DataProcessorDwg
), which sets up the collector layers and metadata, before the Gs tesselates the geometry into theDataProcessor
superclass's methods.View
Blocks
Names
Metadata
Entity Handle::Value
), which contains the hex encoded handle of the object. This handle can be seen in AutoCAD with theLIST
command.Colours
ODCOLORREF
has been replaced withOdCmEntityColor
in theMaterialColours
struct across all ODA importers.DataProcessor
superclass which is used in a number of places.ODCOLORREF
macros are encoding dependent, and a different coding was turning up for DWGs leading to colour channels being swapped.OdCmEntityColor
should handle this transparently.CMake
FindODA.cmake
ODA_LIB_NAMES
variable now has each entry on its own line as is done for the sources and headers, to make diff/change control easierUnit Tests
Things to note