Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE #705 fixes drawing import issues on local #706

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

carmenfan
Copy link
Member

This fixes #705

Description

Convert placeholders to shareDir path on importParams for drawings

this requires 3drepo/3drepo.io#5177

Test cases

cross platform drawing import should now work

Copy link
Contributor

@Charence Charence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is close but there's still one backslash that needs to be a forward slash: inkscape --export-type="svg" /efs/queue/c14c6149-4893-4737-9be9-b1c3ff1fcd70\c14c6149-4893-4737-9be9-b1c3ff1fcd70.pdf -o /efs/queue/c14c6149-4893-4737-9be9-b1c3ff1fcd70/c14c6149-4893-4737-9be9-b1c3ff1fcd70.svg -n 1 -D --export-background=white --export-background-opacity=255

This is the importParams file: # cat /efs/queue/c14c6149-4893-4737-9be9-b1c3ff1fcd70/importParams.json {"format":".pdf","size":107556,"owner":"testlocal","database":"testlocal","project":"b9a8c530-a96d-43ee-9337-6cde424e8208","revId":"c14c6149-4893-4737-9be9-b1c3ff1fcd70","file":"/efs/queue/c14c6149-4893-4737-9be9-b1c3ff1fcd70\\c14c6149-4893-4737-9be9-b1c3ff1fcd70.pdf"}#

@Charence Charence merged commit a908553 into staging Sep 25, 2024
14 of 16 checks passed
@Charence Charence deleted the ISSUE_705 branch September 25, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants