Fix IndexError when calling subprocess

3liz · Dec 19, 2023 · 0eef68b · 0eef68b
1 parent 3a0bdab
commit 0eef68b
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -107,7 +107,7 @@ jobs:
       - name: Package and deploy the zip
         run: >-
           qgis-plugin-ci
-          -vv
+          -v
           release ${{ env.RELEASE_VERSION }}
           --github-token ${{ secrets.BOT_HUB_TOKEN }}
           --transifex-token ${{ secrets.TRANSIFEX_TOKEN }}

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
@@ -34,7 +34,7 @@ package-zip:
   script:
     - >
       qgis-plugin-ci
-      -vv
+      -v
       package ${VERSION}
       --plugin-repo-url https://packages.3liz.org/pub/lizmap-qgis-plugin/${STATUS}/
       --transifex-token ${TX_TOKEN}

diff --git a/lizmap/tools.py b/lizmap/tools.py
@@ -151,7 +151,13 @@ def current_git_hash() -> str:
         universal_newlines=True,
         encoding='utf8'
     )
-    hash_number = git_show.communicate()[0].partition('\n')[0]
+    try:
+        hash_number = git_show.communicate()[0].partition('\n')[0]
+    except IndexError:
+        # Reported on redmine
+        # IndexError: list index out of range
+        hash_number = ''
+
     if hash_number == '':
         hash_number = 'unknown'
     return hash_number
@@ -169,7 +175,13 @@ def has_git() -> bool:
         universal_newlines=True,
         encoding='utf8'
     )
-    output = git_show.communicate()[0].partition('\n')[0]
+    try:
+        output = git_show.communicate()[0].partition('\n')[0]
+    except IndexError:
+        # Reported on redmine
+        # IndexError: list index out of range
+        output = ''
+
     return output != ''
 
 
@@ -185,7 +197,13 @@ def next_git_tag():
         universal_newlines=True,
         encoding='utf8'
     )
-    tag = git_show.communicate()[0].partition('\n')[0]
+    try:
+        tag = git_show.communicate()[0].partition('\n')[0]
+    except IndexError:
+        # Reported on redmine
+        # IndexError: list index out of range
+        tag = ''
+
     if not tag:
         return 'next'
     versions = tag.split('.')