Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Feature toolbar: child layer is pivot #4966

Merged
merged 1 commit into from
Nov 13, 2024
Merged

[Bugfix] Feature toolbar: child layer is pivot #4966

merged 1 commit into from
Nov 13, 2024

Conversation

rldhont
Copy link
Collaborator

@rldhont rldhont commented Nov 13, 2024

Funded by Le Grand Narbonne

@rldhont rldhont added user interface popup sponsored development This development has been funded javascript Pull requests that update Javascript code run end2end If the PR must run end2end tests or not labels Nov 13, 2024
@github-actions github-actions bot added this to the 3.10.0 milestone Nov 13, 2024
@rldhont
Copy link
Collaborator Author

rldhont commented Nov 13, 2024

Hi @mind84,

I have to update the way isPivot is calculated in FeatureToolbar. It is not because a table has multiple foreign keys, it is a pivot table. We have a checkbox in lizmap plugin to defined it.

@mind84
Copy link
Contributor

mind84 commented Nov 13, 2024

Hi @nboisteault,

sure, I don't see any drawbacks.

Thanks!

@rldhont rldhont merged commit 31b7362 into 3liz:master Nov 13, 2024
20 checks passed
This was referenced Nov 13, 2024
Merged
Merged
@rldhont rldhont deleted the fix-feature-toolbar-pivot branch November 13, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nboisteault nboisteault nboisteault approved these changes

@mdouchin mdouchin Awaiting requested review from mdouchin

Assignees
No one assigned
Labels
backport release_3_8 backport release_3_9 javascript Pull requests that update Javascript code popup run end2end If the PR must run end2end tests or not sponsored development This development has been funded user interface
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rldhont @mind84 @nboisteault @Gustry