Fix feebas mode crashing when map isn't available #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzi
requested changes
Nov 11, 2024
ThibaultLassiaz
force-pushed
the
fix-feebas-mode-good-rod
branch
from
18004da
to
72cc6ad
Compare
hanzi
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here's the issue
For some reasons when entering battle mode on an encounter sometimes map data aren't available causing Feebas mode to be very flaky with some Rods like Good Rod.
Maybe there's a better fix for this issue but I couldn't find why it is flaky like this...
Changes
Skipping the few frames when map data aren't available
Notes
Checklist
--line-length 120argument