Prevent catching modes from starting when no Pokeballs available #497
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where you could start shiny hunting modes without any Poké Balls... because who doesn’t love spotting a shiny you can’t catch ?
I updated these modes so the bot doesn't start if you don't have any Pokéballs or stop if you're out of Pokéballs at the end of an encounter (i.e you captured a Shiny and you're out of Pokéballs)
The Master Ball isn't counted as a valid Pokéball, it will never be used
Changes
run
function to stop if you have no Pokéballson_battle_ended
functions to stop after catching a Shiny and running out of PokéballsNotes
I tested all the modes manually to check for bugs who would prevent the mode to start and it seems fine
Checklist
--line-length 120
argument