Access key check updates #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with S3_URL/SQS_URL env vars.
| @@ -0,0 +1,244 @@ | |||
| import axios from 'axios'; | |||
There was a problem hiding this comment.
This file is not yet used. It is in progress refactor and just wanted it checked in for safe keeping.
netsettler
reviewed
Jul 3, 2023
| @@ -320,7 +376,9 @@ def reactapi_header(self, request: dict, env: str) -> Response: | |||
| if data_portal["ssl_certificate"]: | |||
| data_portal["ssl_certificate"]["name"] = "Portal" | |||
| data_portal["ssl_certificate"]["exception"] = e | |||
| data["timestamp"] = convert_utc_datetime_to_useastern_datetime_string(datetime.datetime.utcnow()) | |||
| data["timestamp"] = convert_utc_datetime_to_local_datetime_string(datetime.datetime.utcnow()) | |||
| import tzlocal # xyzzy temporary | |||
There was a problem hiding this comment.
Please don't import in the middle of a function.
Except to avoid circularity, all imports should be at toplevel and at the top of the file, though even the "it avoids a circularity" imports are probably signs something is structured wrong.
…dates' into access-key-check-updates
…dates' into access-key-check-updates
…dates' into access-key-check-updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main thing here is fix for access key status/refresh check. But bunch of miscellaneous UI related improvements as well.