Local check runner #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmichaels-harvard
requested review from
SooLee,
netsettler and
willronchetti
and removed request for
SooLee
willronchetti
approved these changes
Jul 17, 2023
foursight_core/check_utils.py
Outdated
| @@ -360,7 +362,7 @@ def get_grouped_check_results(self, connection): | |||
| grouped_list = [group for group in grouped_results.values()] | |||
| return sorted(grouped_list, key=lambda v: v['_name']) | |||
|
|
|||
| def run_check_or_action(self, connection, check_str, check_kwargs): | |||
| def obsolete_run_check_or_action(self, connection, check_str, check_kwargs): | |||
There was a problem hiding this comment.
If you're going to rename you may as well remove?
Comment on lines
+519
to
+550
| Info = namedtuple("CheckInfo", ["kind", | ||
| "is_check", | ||
| "is_action", | ||
| "name", | ||
| "qualified_name", | ||
| "file", | ||
| "line", | ||
| "module", | ||
| "unqualified_module", | ||
| "package", | ||
| "github_url", | ||
| "args", | ||
| "kwargs", | ||
| "function", | ||
| "associated_action", | ||
| "associated_check"]) | ||
| return Info(info["kind"], | ||
| info["kind"] == "check", | ||
| info["kind"] == "action", | ||
| info["name"], | ||
| qualified_check_or_action_name(info["name"], info["module"]), | ||
| info["file"], | ||
| info["line"], | ||
| info["module"], | ||
| unqualified_module_name(info["module"]), | ||
| info["package"], | ||
| info["github_url"], | ||
| info["args"], | ||
| info["kwargs"], | ||
| info["function"], | ||
| info.get("action"), | ||
| info.get("check")) |
There was a problem hiding this comment.
Does this really serve any purpose if you're not going to use outside of this function? You might consider moving this somewhere it can be used more widely ie: helper function that builds.
| _original_stderr = sys.stderr | ||
|
|
||
| @contextmanager | ||
| def captured_output(capture: bool = True): |
There was a problem hiding this comment.
Seems like a good candidate for utils
| return aws_credentials_name | ||
|
|
||
|
|
||
| def confirm_interactively(message: str, exit_if_no: bool = False) -> bool: |
There was a problem hiding this comment.
You have code very similar to this in 4dn-cloud-infra you could also bring into utils ie: arg_utils ?
pyproject.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [tool.poetry] | |||
| name = "foursight-core" | |||
| version = "4.4.0" | |||
| version = "4.4.0.1b1" # TODO: To become 4.4.1 | |||
There was a problem hiding this comment.
I would definitely consider minor version here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command-line (poetry) script (local-check-runner) to run checks locally, so people don't have to cobble together their own. Usage looks like this: local-check-runner access_key_expiration_detection/access_key_status ... to run this check. If you want to run any associated action after the check runs then specify the --action option. Can also list all known checks. Went to some care to ensure a lot of seeming garbage logging is not output to confuse/confound the user.