-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Python 3.11 #52
Conversation
.github/workflows/main-CI.yml
Outdated
@@ -26,7 +26,7 @@ jobs: | |||
- uses: actions/checkout@v2 | |||
- uses: actions/setup-python@v2 | |||
with: | |||
python-version: '3.7' | |||
python-version: '3.8' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to use 3.11 for CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the issue about whether to do matrix testing or not. Will should weigh in on that. Otherwise this looks fine.
.github/workflows/main-CI.yml
Outdated
@@ -26,7 +26,7 @@ jobs: | |||
- uses: actions/checkout@v2 | |||
- uses: actions/setup-python@v2 | |||
with: | |||
python-version: '3.7' | |||
python-version: '3.8' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the theory here that the actual foursight-<portal>
repos will test this enough that we don't need to do all versions? Do the tests for this take a long time? I otherwise think this should maybe have a matrix of 3.8, 3.9, 3.10, 3.11. Thoughts, @willronchetti ?
@@ -11,11 +11,11 @@ packages = [ | |||
] | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. There are no classifiers here. I guess we don't have to fix that now. It's of questionable value anyway. But I noticed because I was checking to see if they were updated.
…y; speeds up 4dn-cloud-infra provision a LOT.
No description provided.