-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get info about workflows and pipelines from db instead of hard coding #577
Conversation
assert wfr_name in workflow_details | ||
assert key | ||
workflow_details = get_workflow_details(key) | ||
assert wfr_name in workflow_details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran into an error at this point in a check running--it looks like workflow_details
is just {}
. I will keep exploring!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense as the properties that were added to the Workflow and ExperimentType items are not in webdev and I guess the version of fourfront there is likely prior to the schema changes so they can't be added. Note that for testing particular workflows you can pass in this info as a parameter but that kind of defeats some of the purpose of testing. I will consider options for making this backward compatible so it can be used on webdev without errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, of course!
…ns without output to support kwargs
Okay, I managed to get a QC workflow to run and patch on webdev, as well as a processing workflow using the stepper function. It was a little tricky to get working on webdev for the processing pipeline, but it definitely works. I guess I'll turn the review back to you for the addition to prevent fastq-first-line from running over 2 errors and to bump versions. |
Needs careful review and testing