Bug fix for outdated code in the set higlass defaults action #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in this check was using outdated functions to obtain info from s3 buckets that was used to generate coloring for multivec files for higlass.
Turns out there was only one of these files (likely used for testing when this check and action were created) but we recently received a couple more files that need this check/action run.
This update after a re-factor in a previous PR fixes a remaining bug - indirectly by incorporating an update to dcicutils.s3_utils to allow a bucket name to be passed to the read_s3 method.
This was tested locally and successfully added the higlass defaults to the 2 new files that needed them.