Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for GA publish and CI builds for Python 3.8, 3.9, 3.10, and 3.11 #398

Merged
merged 29 commits into from
Oct 6, 2023

Conversation

dmichaels-harvard
Copy link
Collaborator

@dmichaels-harvard dmichaels-harvard commented Oct 6, 2023

  • Fixed GA publish which was not working because it could not find dcicutils because it is not a dependency in pyproject.toml; workaround is to call it manually via straight python and not via pyproject.toml script. N.B. It still does not work because pypi project credentials are not yet defined for this repo.
  • Added Python 3.8, 3.9, 3.10, as well as 3.11 for GA CI build. This caused failures because of the way the tests were written - writing/reading to/from fixed location in S3 - which means that concurrent runs do not reliably succeed, i.e. because they are stomping on each other. Workaround was to define separate build steps (cloned for now) in main.yml with appropriate "needs" clauses which forces them to execute serially. (The real fix of course is to fix this tests - and note of course they tests can still fail if someone somewhere happens to be running the tests locally at the same time)

Copy link
Member

@alexander-veit alexander-veit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks ok to me. Certainly, the tests should be rewritten, so that the sequential GA testing is not necessary. But... that's a lot of work.

@dmichaels-harvard dmichaels-harvard merged commit adc0866 into master Oct 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants