Skip to content

Commit

Permalink
Fix iOS automatic exports when using admob (#6986)
Browse files Browse the repository at this point in the history
* internal ios deployment-target was conflicting between the plugins used, when admob was used in the project, preventing to build the app
  • Loading branch information
ClementPasteau authored Sep 25, 2024
1 parent 1fa3f59 commit 02c06ac
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 20 deletions.
4 changes: 4 additions & 0 deletions GDJS/Runtime/Cordova/config.xml
Original file line number Diff line number Diff line change
Expand Up @@ -63,4 +63,8 @@
<preference name="phonegap-version" value="cli-9.0.0" />

<!-- GDJS_EXTENSION_CORDOVA_DEPENDENCY -->

<!-- Keep cordova-plugin-ionic-webview plugin last as it has a deployment-target to 11, which
affects the installation of other plugins.-->
<plugin name="cordova-plugin-ionic-webview" version="5.0.1" />
</widget>
32 changes: 12 additions & 20 deletions GDJS/Runtime/Cordova/package.json
Original file line number Diff line number Diff line change
@@ -1,22 +1,14 @@
{
"name": "GDJS_GAME_MANGLED_NAME",
"displayName": "GDJS_GAME_NAME",
"version": "GDJS_GAME_VERSION",
"description": "GDJS_GAME_NAME",
"main": "index.js",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
},
"keywords": [
"ecosystem:cordova"
],
"author": "GDJS_GAME_AUTHOR",
"devDependencies": {
"cordova-plugin-ionic-webview": "5.0.0"
},
"cordova": {
"plugins": {
"cordova-plugin-ionic-webview": {}
}
}
"name": "GDJS_GAME_MANGLED_NAME",
"displayName": "GDJS_GAME_NAME",
"version": "GDJS_GAME_VERSION",
"description": "GDJS_GAME_NAME",
"main": "index.js",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
},
"keywords": [
"ecosystem:cordova"
],
"author": "GDJS_GAME_AUTHOR"
}

0 comments on commit 02c06ac

Please sign in to comment.